Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for toxic_domains list #577

Closed
KonoromiHimaries opened this issue Oct 11, 2018 · 2 comments · Fixed by #675
Closed

add support for toxic_domains list #577

KonoromiHimaries opened this issue Oct 11, 2018 · 2 comments · Fixed by #675
Labels
directory-data changes to basic FilterLists data

Comments

@KonoromiHimaries
Copy link
Contributor

Adding or Updating Lists?

https://www.stopforumspam.com/downloads

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Oct 11, 2018
@DandelionSprout
Copy link
Contributor

DandelionSprout commented Oct 12, 2018

I had previously been unaware that StopForumSpam had domain versions á la https://www.stopforumspam.com/downloads/toxic_domains_whole.txt, so that was actually a great find. 👍

But I'm waiting out on adding your recentmost suggestions, both in expectation of #372, and because I've grown slightly tired of having to cobble together all the needed information myself (For example licences, descriptions, E-mail addresses, tags, etc.), especially as I've had to spend some of my energy this week on dealing with translations and PC upgrades. It's not too difficult to make pull requests to add lists like these, and I'm confident that Collin would've appreciated the effort and would be more than happy to correct any theorethical syntax mistakes.

@collinbarrett
Copy link
Owner

Agreed. Still feel free to open issues for new lists, @KonoromiHimaries , that's great. But, PRs are even better.

I try to focus my time on features. @DandelionSprout has been a tremendous help on maintaining data, but I know #372 is really needed. It's just a big undertaking, and I'm not sure the best approach yet.

collinbarrett pushed a commit that referenced this issue Jan 21, 2019
* NeoHosts

* StopForumSpam Toxic Domains Whole

* added license

* qwerty

* Update FilterList.json

* Update FilterList.json

* Update FilterList.json

* Update FilterList.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants