Testing out #467 #469
Testing out #467 #469
Conversation
|
Cool. FYI, #467 is not implemented yet, so you won't actually see these mirrors in the UI. Feel free to subscribe to that issue to be notified when it is. |
Done. 🙂 |
data/FilterList.json
Outdated
| @@ -5120,8 +5120,8 @@ | |||
| "submissionUrl": null, | |||
| "syntaxId": 3, | |||
| "viewUrl": "https://easylist-downloads.adblockplus.org/fanboy-annoyance.txt", | |||
| "viewUrlMirror1": null, | |||
| "viewUrlMirror2": null | |||
| "viewUrlMirror1": "https://fanboy.co.nz/fanboy-social.txt", | |||
There was a problem hiding this comment.
Fanboy Social and Fanboy Annoyance are different lists, I think. So, probably not mirrors.
There was a problem hiding this comment.
Ah, thanks for spotting.
data/FilterList.json
Outdated
| @@ -206,8 +206,8 @@ | |||
| "submissionUrl": "https://www.malwaredomainlist.com/contact.php", | |||
| "syntaxId": 1, | |||
| "viewUrl": "https://www.malwaredomainlist.com/hostslist/hosts.txt", | |||
| "viewUrlMirror1": null, | |||
| "viewUrlMirror2": null | |||
| "viewUrlMirror1": "https://cdn.rawgit.com/NanoMeow/MDLMirror/master/hosts.txt", | |||
There was a problem hiding this comment.
these aren't really mirrors since they are a different syntax (hosts vs domains). should probably be separate lists in FilterList.json and linked in Fork.json
There was a problem hiding this comment.
...or just not added as mirrors for now, if you don't want to spend the time with that. I just think we should keep mirrors pretty strictly to "mirrors" (exact copies of the original).
There was a problem hiding this comment.
In that case it's slightly odd that https://github.com/gorhill/uBlock/blob/master/assets/assets.json seems to think of them as being the same list.
|
The two errors should have been resolved now. |
I made a quick pull to test out the mirror linking. I chose to keep it pretty simple for now, only adding my own mirror and the non-uBO-hosted mirrors on their assets.json list.
I am also removing two lists of mine that I am planning to discontinue and delete in the very near future: Norwegian Cashback Helper because its functionality has long since been incorporated into the main Norwegian list (and because there was insufficient public demand to undo the incorporation), and the iOS list because I couldn't prove that it was even possible to add custom lists with that specific syntax to any iOS Safari extensions.