-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for DROP IF EXISTS clause #115
Conversation
There was 1 error:
1) Colopl\Spanner\Tests\Schema\BlueprintTest::test_dropIfExists
Google\Cloud\Core\Exception\BadRequestException: {
"message": "Error parsing Spanner DDL statement: drop table if exists `Test3` : Syntax error on line 1, column 12: Encountered 'if' while parsing: identifier",
"code": 3,
"status": "INVALID_ARGUMENT",
"details": [
{
"@type": "grpc-status-details-bin",
"data": "<Unknown Binary Data>"
}
]
}
/project/vendor/google/cloud-core/src/GrpcRequestWrapper.php:263
/project/vendor/google/cloud-core/src/GrpcRequestWrapper.php:151
/project/vendor/google/cloud-core/src/GrpcTrait.php:82
/project/vendor/google/cloud-spanner/src/Connection/Grpc.php:691
/project/vendor/google/cloud-spanner/src/Database.php:517
/project/src/Concerns/ManagesDataDefinitions.php:62
/project/src/Connection.php:306
/project/tests/Schema/BlueprintTest.php:94
ERRORS!
Tests: 108, Assertions: 374, Errors: 1, Skipped: 2. According to the documentation, the https://cloud.google.com/spanner/docs/reference/standard-sql/data-definition-language#drop_table |
Waiting for emulator to add support. |
I've changed the title to DRAFT |
e48ad4b
to
532c1db
Compare
Co-authored-by: Tomohito YABU <tyabu1212@gmail.com>
e372e65
to
fa39860
Compare
fa39860
to
c1fec4f
Compare
Emulator added support and tests are now passing. https://github.com/GoogleCloudPlatform/cloud-spanner-emulator/releases/tag/v1.5.7 |
Fix: #111
Checklist