Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color spaces should be defined by ColorSpace objects #113

Closed
LeaVerou opened this issue Nov 11, 2021 · 2 comments
Closed

Color spaces should be defined by ColorSpace objects #113

LeaVerou opened this issue Nov 11, 2021 · 2 comments
Assignees
Labels
color-api Parity with the Color API

Comments

@LeaVerou
Copy link
Member

Currently Color spaces are defined by object literals.
In the Color API we used ColorSpace objects. There might be value in using such objects here as well, e.g. the ability to create anonymous color spaces that aren't available globally via ids. It will also make typings easier I suppose.

@LeaVerou LeaVerou added the color-api Parity with the Color API label Nov 11, 2021
@svgeesus
Copy link
Member

Although those objects currently have:

readonly attribute CSSOMString? iccProfile;

and see #45

@LeaVerou
Copy link
Member Author

Yeah, ours wouldn't have that attribute (yet). 🤷🏽‍♀️

@LeaVerou LeaVerou self-assigned this Jun 18, 2022
LeaVerou added a commit that referenced this issue Jun 21, 2022
- Use ColorSpace (and RGBColorSpace) objects instead of ad hoc literals. Fixes #113
- Use shorter coordinate names, fixes #144
- Explicit range vs reference range distinction
- Remove Color.defineSpace() as we are not using it anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color-api Parity with the Color API
Projects
None yet
Development

No branches or pull requests

2 participants