Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct rec2100-hlg, #190 #271

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Correct rec2100-hlg, #190 #271

merged 1 commit into from
Jan 16, 2023

Conversation

svgeesus
Copy link
Member

Fix wildly incorrect REC.2100 HLG encoding and decoding:

  • Parts of the code assumed [0,1] was SDR range, others that it was HDR range
  • The EOTF and OEFT from BT.2390-10 were the wrong way round
  • implemented a scaling factor to place 18% grey at 38% and SDR white at 75%
  • also fixed parse error in color(rec2020-linear ...)

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Obviously I haven't really checked the math, but the actual code changes look good.

@LeaVerou LeaVerou merged commit f3791da into main Jan 16, 2023
@LeaVerou LeaVerou deleted the fix-hlg branch January 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants