Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types] Add .js extension to file imports #333

Merged
merged 3 commits into from
Oct 9, 2023
Merged

[types] Add .js extension to file imports #333

merged 3 commits into from
Oct 9, 2023

Commits on Oct 8, 2023

  1. [types] Add .js extension to file imports 

    Fixes problems when `moduleResolution` in tsconfig.json is set to
NodeNext.
    @MysteryBlokHed
    MysteryBlokHed committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    e45597c View commit details
    Browse the repository at this point in the history

  2. [types] Add extensions to import() types

    @MysteryBlokHed
    MysteryBlokHed committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    e27c929 View commit details
    Browse the repository at this point in the history

  3. [types] Add missing imports 

    Weirdly, TypeScript only complains about these imports when
`moduleResolution` is set to `NodeNext`. I guess that whatever the
default module resolution system is can infer that they're from the
augmented module, but that doesn't seem to work on `NodeNext`.
    @MysteryBlokHed
    MysteryBlokHed committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    4fae707 View commit details
    Browse the repository at this point in the history