Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse dashed-ident color() ids. #407

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Parse dashed-ident color() ids. #407

merged 1 commit into from
Feb 8, 2024

Conversation

jgerigmeyer
Copy link
Member

@jgerigmeyer jgerigmeyer commented Feb 7, 2024 •
edited by svgeesus
Loading

  • Adds ids for CAM16-JMh and HCT spaces
  • Fixes typo in REC.2100-HLG cssId
  • Parses both <dashed-ident> and non-<dashed-ident> versions of color space ids

Fixes #405

@netlify Netlify
Copy link

netlify bot commented Feb 7, 2024 •
edited
Loading

✅ Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit 507aba9
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/65c3bd0b786939000809089d
😎 Deploy Preview https://deploy-preview-407--colorjs.netlify.app/tests/parse
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgerigmeyer jgerigmeyer mentioned this pull request Feb 7, 2024
Closed
LeaVerou
LeaVerou approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jgerigmeyer jgerigmeyer merged commit 2ba72b7 into color-js:main Feb 8, 2024
4 checks passed
@jgerigmeyer jgerigmeyer deleted the dashed-ident branch February 8, 2024 15:44
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 3, 2024
Open
@Carolinewly Carolinewly mentioned this pull request Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeaVerou LeaVerou LeaVerou approved these changes

@facelessuser facelessuser Awaiting requested review from facelessuser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use <dashed-ident> for CAM16-JMh and HCT
2 participants
@jgerigmeyer @LeaVerou