-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gamut mapping App] Add port of Chromium Gamut mapping app #485
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wow, thanks for this! Why the change from |
The issue & description refer to it as "baked in", so I thought I would mirror the other methods, and name this by the methodology rather than source. I suspect there to be a large number of variations on what "baked-in" means, so if we add additional ones, we may want to add the provenance, e.g., |
I do think for comparison purposes, this approach should clip to Display P3. Right now, you are comparing P3 deltas with Chromiums Rec. 2020 deltas, which makes the whole thing unhelpful. Visually, the browser will clip to whatever the display is using, but for raw number comparison purposes, we need actual P3 values. |
@facelessuser Good point- update pushed! |
I have no opinions on name. As a suggestion, you could call it chromium and reference the "baked-in" part in the description. Other than that, it all LGTM at this point. |
Good idea- done! |
I think all of the issues everyone had have been addressed. It seems to yield the same results that Chromium does when the GMA flag is enabled as well. Since this doesn't affect core code at all, I will go ahead and merge this. |
This ports the algorithm available behind a flag in Chrome Canary, implemented here.
The approach appears to be different from the others, reach roughly the same results as the CSS algorithm, and is as fast as clip.
I expect that there could be additional cleanup, this was intended to be as straight of a port as possible from the original code.