Remove formatting changes from PR #540 #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dmitry Sharabin <dmitrysharabin@gmail.com>
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Should the target branch for this be |
It definitely should. Thank you for pointing this out! Fixed. |
LeaVerou
approved these changes
Jun 8, 2024
LeaVerou
merged commit 78b1db7
into
color-js:types/migrate-to-jsdoc
4 of 5 checks passed
LeaVerou
pushed a commit
that referenced
this pull request
Jun 10, 2024
* style: npm run lint * feat: Initial conversion to JSDoc types * style: Fix accidental formatting changes * feat: Remove old `.d.ts` files * feat: Point `build:space-accessors` script to new location * feat: Add JSDoc types for contrast methods * feat: Add JSDoc types for deltaE * fix: Remove garbage from tsconfig.json * fix: Add DOM to tsconfig.json `lib` * feat: Re-export types from `contrast` and `deltaE` * feat: Point config files away from old `.d.ts` * feat(types): Add some JSDoc to spaces Since spaces use classes, most of the typing doesn't need to be done explicitly; JSDoc was just added to other exported functions of some spaces. * docs: Add `@packageDocumentation` from removed `.d.ts` * fix: Type error in util.js * feat(types): Document remaining exported space members * feat: Update `Format` and `Type` classes * docs: Include `types.d.ts` as entrypoint * docs: Add `@internal` note to Format symbol * fix: Leftover merge conflict stuff I have no idea how I let this through! * fix: Typo in ColorSpace.d.ts Co-authored-by: Dmitry Sharabin <dmitrysharabin@gmail.com> * Fix dtslint * Swap allowJs/checkJs * Remove formatting changes from PR #540 (#541) * [CATs.js] Remove the formatting changes * Update ColorSpace.js * Update RGBColorSpace.js * Update adapt.js * Update chromaticity.js * Update color.js * Update contrast.js * Update deltaE.js * Update display.js * Update distance.js * fix: Typo in ColorSpace.d.ts Co-authored-by: Dmitry Sharabin <dmitrysharabin@gmail.com> * Update equals.js * Update get.js * Update inGamut.js * Update interpolation.js * Update multiply-matrices.js * Update parse.js * Update cam16.js * Update to.js * Update variations.js * Update serialize.js * Update set.js * Update setAll.js * Update toGamut.js * Update util.js --------- Co-authored-by: Adam Thompson-Sharpe <adamthompsonsharpe@gmail.com> * style: Undo formatting change in ColorSpace.js --------- Co-authored-by: Dmitry Sharabin <dmitrysharabin@gmail.com> Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a branch of the corresponding PR. Its primary purpose is to facilitate reviewing the actual changes in #540.