Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Replace pygraphviz with pydot. #1298

Merged
merged 1 commit into from
Oct 8, 2024
Merged

PR: Replace pygraphviz with pydot. #1298

merged 1 commit into from
Oct 8, 2024

Conversation

KelSolaar
Copy link
Member

Summary

This PR replaces pygraphviz with pydot so that installation is easier: pygraphviz needs to be built whereas pydot is a pure Python package.

This simplifies the installation process tremendously by avoiding issues such as pygraphviz/pygraphviz#11

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • [N/A] The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.5 milestone Oct 8, 2024
@coveralls
Copy link

Coverage Status

coverage: 99.835%. remained the same
when pulling b62105b on feature/pydot
into b83a73d on develop.

@KelSolaar KelSolaar merged commit 398221a into develop Oct 8, 2024
25 of 26 checks passed
@KelSolaar KelSolaar deleted the feature/pydot branch October 8, 2024 06:31
@KelSolaar KelSolaar mentioned this pull request Oct 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants