Simplify tile renderer, improve stitching and caching #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method uses the composite() method of sharp to reduce the number of times a PNG buffer is created. The number could be further reduced from two to one, if the issue #1908 from lovell/sharp is resolved so that composite and resize can be chained without an intermediate call to .png().toBuffer()
|
Apparently sharp requires to create two processing pipelines in the stitching step (first composite, then resize) so this is the best we can get. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #438, and contains the following fixes/improvements:
composite()rather than multipleoverlayWith()calls, which reduces the number of times a.png().toBuffer()sequence is called from 5 to 2. Without precise testing, on a local server this seems to result in a performance improvement at lower zoom levels. An issue was created against sharp (Using resize after composite causes merging of composited images? lovell/sharp#1908) related to a problem with compositing and then resizing which seemingly prevents us from being able to complete the operations in just one pipeline.base_lightandbase_nightlayers were not being cached. This has now been amended and a mechanism added to not clear these layers on building data edit