Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross publish acyclic against full scala version #42

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Cross publish acyclic against full scala version #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7ef3b1
.
lihaoyi Nov 29, 2021
e47bf56
Update readme.md
lihaoyi Nov 29, 2021
3af0cab
Update readme.md
lihaoyi Nov 30, 2021
e53e83c
Update readme.md
lihaoyi Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions acyclic/src/acyclic/plugin/PluginPhase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,7 @@ class PluginPhase(val global: Global,
case Value.File(_, _) =>
}

units.find(_.source.path == locs.head.pos.source.path)
.get
.echo(locs.head.pos, "")
global.reporter.echo(locs.head.pos, "")

val otherLines = locs.tail
.map(_.pos.line)
Expand Down
7 changes: 6 additions & 1 deletion build.sc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@ import mill._, scalalib._, publish._
import $ivy.`de.tototec::de.tobiasroeser.mill.vcs.version_mill0.9:0.1.1`
import de.tobiasroeser.mill.vcs.version.VcsVersion

object acyclic extends Cross[AcyclicModule]("2.11.12", "2.12.8", "2.13.0")
object acyclic extends Cross[AcyclicModule](
"2.11.12",
"2.12.8", "2.12.9", "2.12.10", "2.12.11", "2.12.12", "2.12.13", "2.12.14", "2.12.15",
"2.13.0", "2.13.1", "2.13.2", "2.13.3", "2.13.4", "2.13.5", "2.13.6", "2.13.7"
)
class AcyclicModule(val crossScalaVersion: String) extends CrossScalaModule with PublishModule {
def crossFullScalaVersion = true
def artifactName = "acyclic"
def publishVersion = VcsVersion.vcsState().format()

Expand Down
13 changes: 11 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,18 @@ How to Use
To use, add the following to your `build.sbt`:

```scala
libraryDependencies += "com.lihaoyi" %% "acyclic" % "0.1.7" % "provided"
libraryDependencies += "com.lihaoyi" %% "acyclic" % "0.3.0" cross (CrossVersion.full) % "provided"

autoCompilerPlugins := true

addCompilerPlugin("com.lihaoyi" %% "acyclic" % "0.1.7")
addCompilerPlugin("com.lihaoyi" %% "acyclic" % "0.3.0")
```

For Mill, use the following:

```scala
def compileIvyDeps = Agg(ivy"com.lihaoyi:::acyclic:0.3.0")
def scalacPluginIvyDeps = Agg(ivy"com.lihaoyi:::acyclic:0.3.0")
```

If you are on Scala 2.10.x, you may need an additional compile-time dependency:
Expand Down Expand Up @@ -230,6 +237,8 @@ Acyclic has problems in a number of cases:
ChangeLog
=========

**0.3.0**: Cross-build across all scala point versions

**0.2.0**: Support for Scala 2.13.0 final

**0.1.7**: Fix `import acyclic.skipped`, which was broken in 0.1.6
Expand Down