Omit the suffix in artifactName for cross modules (#953)

Pull request: #953
com-lihaoyi · Oct 21, 2020 · 81ae1dc · 81ae1dc
1 parent 2f9b633
commit 81ae1dc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/scalalib/src/MiscModule.scala b/scalalib/src/MiscModule.scala
@@ -16,6 +16,7 @@ trait CrossModuleBase extends ScalaModule {
   def scalaVersion = T{ crossScalaVersion }
 
   override def millSourcePath = super.millSourcePath / ammonite.ops.up
+  override def artifactName: T[String] = millModuleSegments.parts.init.mkString("-")
   implicit def crossSbtModuleResolver: Resolver[CrossModuleBase] = new Resolver[CrossModuleBase]{
     def resolve[V <: CrossModuleBase](c: Cross[V]): V = {
       crossScalaVersion.split('.')

diff --git a/scalalib/test/src/HelloWorldTests.scala b/scalalib/test/src/HelloWorldTests.scala
@@ -492,6 +492,13 @@ object HelloWorldTests extends TestSuite {
       }
     }
 
+    'artifactNameCross - {
+      workspaceTest(CrossHelloWorld) { eval =>
+        val Right((artifactName, _)) = eval.apply(CrossHelloWorld.core("2.13.1").artifactName)
+        assert(artifactName == "core")
+      }
+    }
+
     'runMain - {
       'runMainObject - workspaceTest(HelloWorld){eval =>
         val runResult = eval.outPath / 'core / 'runMain / 'dest / "hello-mill"