Skip to content

Commit

Permalink
cleanup2
Browse files Browse the repository at this point in the history
  • Loading branch information
jodersky committed Nov 30, 2024
1 parent f908ba5 commit 99cf644
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
4 changes: 2 additions & 2 deletions pythonlib/src/mill/pythonlib/PublishModule.scala
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ trait PublishModule extends PythonModule {
* distribution (sdist and wheel).
*
* By default, Mill will generate this file for you from the information it knows (e.g.
* dependencies declared in [[pythonDeps]]). It will use `PublishModule` as the build backend, and
* dependencies declared in [[pythonDeps]]). It will use `setuptools` as the build backend, and
* `build` as the frontend.
*
* You can however override this task to point to your own `pyproject.toml` file, if you need to.
Expand All @@ -53,7 +53,7 @@ trait PublishModule extends PythonModule {
* - Hence, the source distribution will need to be "self contained". In particular this means
* that you can't reference files by absolute path within it.
*
* - Mill creates a "staging" directory in the [[build]] task, which will be used to bundle
* - Mill creates a "staging" directory in the [[sdist]] task, which will be used to bundle
* everything up into an sdist (via the `build` python command, although this is an
* implementation detail). You can include additional files in this directory via the
* [[buildFiles]] task.
Expand Down
11 changes: 0 additions & 11 deletions pythonlib/src/mill/pythonlib/PythonModule.scala
Original file line number Diff line number Diff line change
Expand Up @@ -180,17 +180,6 @@ trait PythonModule extends PipModule with TaskModule { outer =>
override def moduleDeps: Seq[PythonModule] = Seq(outer)
}

// // wheels and sdist belong to every PythonModule, but setup tools don't
// /** Package this python module as a wheel. */
// def wheel: T[PathRef] = T {
// PathRef(runSetupPy().path / "???")
// }

// /** Package this python module as a source distribution (sdist). */
// def sdist: T[PathRef] = Task {
// PathRef(runSetupPy().path / "???")
// }

}

object PythonModule {
Expand Down

0 comments on commit 99cf644

Please sign in to comment.