Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False warning in docs #2906

Closed
asarkar opened this issue Dec 7, 2023 · 4 comments · Fixed by #3024
Closed

False warning in docs #2906

asarkar opened this issue Dec 7, 2023 · 4 comments · Fixed by #3024
Milestone

Comments

@asarkar
Copy link

asarkar commented Dec 7, 2023

https://mill-build.com/mill/Installation_IDE_Support.html#_build_server_protocol_bsp

As of writing this, Metals 0.11.8 is the latest available version, which is not able to detect the fact, that Mill is already providing SemanticDB data. As a consequence, it reports missing SemanticDB data, although some SemanticDB-based features are already working. This may be fixed eventually in a future release of Metals.

According to metals#5922, this is no longer an issue.

@lefou
Copy link
Member

lefou commented Dec 7, 2023

Nice! We can update the docs once the Metals release is out.

@asarkar
Copy link
Author

asarkar commented Dec 7, 2023

I believe they're saying this is not an issue already, and the warning is a false positive. The next Metals release would remove the warning, but the Mill docs could at least mention that the warning can be ignored. I spent few hours trying to get rid of the warning, so, I can see someone else also mislead by it.

@lefou
Copy link
Member

lefou commented Dec 7, 2023

I believe they're saying this is not an issue already, and the warning is a false positive. The next Metals release would remove the warning, but the Mill docs could at least mention that the warning can be ignored. I spent few hours trying to get rid of the warning, so, I can see someone else also mislead by it.

I'm myself not a native English speaker, but the documentation is in my opinion exactly reproducing the current situation.

As of writing this, Metals 0.11.8 is the latest available version, which is not able to detect the fact, that Mill is already providing SemanticDB data. As a consequence, it reports missing SemanticDB data, ...

This means, Metals will report an error

... although some SemanticDB-based features are already working.

and this means, we already provide it.

This may be fixed eventually in a future release of Metals.

and this means, the false positive reported error will go away with some future release.

But, as you currently witnessed, the falsely reported error isn't fixed yet.

@lefou
Copy link
Member

lefou commented Feb 19, 2024

It looks to me, that current Metals 1.2.2 no longer shows spurious warning about semanticdb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants