Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt logger disappears after mill clean #4074

Closed
lihaoyi opened this issue Dec 5, 2024 · 0 comments · Fixed by #4075
Closed

Prompt logger disappears after mill clean #4074

lihaoyi opened this issue Dec 5, 2024 · 0 comments · Fixed by #4075
Milestone
0.12.4

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Dec 5, 2024 •
edited
Loading

./mill clean; ./mill __.compile doesn't always show the prompt during compilation, especially the second time it is run consecutively. rm -rf out/; ./mill __.compile does seem to show the prompt reliably every time. Mill 0.12.3
@lihaoyi lihaoyi mentioned this issue Dec 5, 2024
Merged
lihaoyi added a commit that referenced this issue Dec 6, 2024
@lihaoyi
More fixes for prompt logger (#4075)
46a199e 
Fixes #4074

We shouldn't sleep for `nonInteractivePromptUpdateIntervalMillis` every
time `readTerminalDims` fails, because that means if there's a transient
failure it doesn't check again for 60s during which there is no prompt
shown

Instead, we always check after `promptUpdateIntervalMillis` seconds, and
but only refresh the prompt if `now - lastUpdate >
nonInteractivePromptUpdateIntervalMillis`

Also we make sure we call `writeTerminalDims` at least once before we
start the Mill background process, rather than relying on the background
thread to reach that code path in time

Either of these fixes alone should solve the issue, but might as well do
both
@lefou lefou added this to the 0.12.4 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.4
Development

Successfully merging a pull request may close this issue.

More fixes for prompt logger lihaoyi/mill-1
2 participants
@lihaoyi @lefou