Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a minimal unit test for scalaplugin/ #8

Closed
lihaoyi opened this issue Nov 22, 2017 · 2 comments
Closed

Write a minimal unit test for scalaplugin/ #8

lihaoyi opened this issue Nov 22, 2017 · 2 comments
Assignees
@rockjam

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Nov 22, 2017 •
edited
Loading

#2 will be an integration test for the module, but we really should have a truly "hello world" unit test that exercises it's functionality in as little code/complexity as possible.

Once we have unit tests, we can start adding more functionality to the scalaplugin/ package, which we currently cannot do since testing it is manual and annoying. e.g. TestModule helpers which come with test pre-defined, SbtModule helpers which come with main+test in one bundle.
@lihaoyi
Copy link
Member Author

lihaoyi commented Nov 26, 2017

@jeffusan have you had time to take a look at this?

@rockjam
Copy link
Collaborator

rockjam commented Nov 26, 2017

I'm on it. Will push some tests soon

rockjam added a commit that referenced this issue Nov 26, 2017
@rockjam
fix #8 simple 'hello world' scala module with tests on it; extract te…
bd793cb 
…st evaluator
rockjam added a commit that referenced this issue Nov 27, 2017
@rockjam
fix #8 simple 'hello world' scala module with tests on it; extract te…
8c5e7b0 
…st evaluator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rockjam rockjam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lihaoyi @rockjam @jeffusan