Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piggyback on ammonite's BSP implementation for build files #971

Closed
Baccata opened this issue Oct 5, 2020 · 1 comment
Closed

Piggyback on ammonite's BSP implementation for build files #971

Baccata opened this issue Oct 5, 2020 · 1 comment

Comments

@Baccata
Copy link
Contributor

Baccata commented Oct 5, 2020

The BSP implementation (which allows editors to talk to mill when the user edits module files) is becoming first-class-citizen in mill, it'd be interesting to piggyback on ammonite's BSP implementation for build.sc, to get all the autocompletion/navigation features metals users would like to have when editing mill build files.

A few possibly relevant details

Mill's entrypoint that ties it to ammonite is there. This method outputs a "Evaluator", which is a construct that is aware of the build-graph and able to evaluate mill-tasks. It is is used by the BSP implementation. The evaluator potentially be accompanied by the information required by ammonite's bsp, in order to enrich mill's bsp for build-files.

One essential thing, specific to mill, that differs from ammonite is the codeWrapper, which would have to be communicated to the ammonite's bsp somehow. The classpath is also obviously different.

@alexarchambault 👋 , could I ask you for a brain-dump when you have time, on how such an integration would be possible ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants