fix sourceItem for mill-build

[camper42]

due to hardcode sourceItem(evaluator.rootModule.millSourcePath / "src", generated = false),
Metals not recognize build.sc as source file when user choose mill-bsp build server,
no auto-complete and hover tooltips available

This commit fix #1159

[lefou]

This hardcodes the build file, which is ok, but will miss any included file.

E.g. in mill we have some additional files:

import $file.ci.shared
import $file.ci.upload

Those will still be missing.

[heksesang]

This hardcodes the build file, which is ok, but will miss any included file.

E.g. in mill we have some additional files:

import $file.ci.shared
import $file.ci.upload

Those will still be missing.

Won't those be imported by regular ammonite support?

[lefou]

AFAIK, mill BSP server does not provide any "regular" ammonite support (yet, see #971). So, either you mean the native support of your editor, or some separately started ammonite BSP server. But neither will have any knowledge of the right classpath to be used.

[heksesang]

I was thinking of the editor support. But I forgot about that point, that if the separate files depend on the classpath as well, that support won't be enough.

Does Ammonite have anything that lets us obtain a list of $file-references in a script?

[lefou]

I don't know Ammonite well enough, but I think the answer is yet. Ammonite itself seems to provide BSP support, so the best would be to look into that implementation.

Back to this concrete PR, as src is in almost all cases not the right setting, but build.sc is probably too restricted. Have you tried to just set the source path of mill-build root project to . or millSourcePath?

[camper42]

Have you tried to just set the source path of mill-build root project to . or millSourcePath?

set source path to . or millSourcePath may be inappropriate too

https://build-server-protocol.github.io/docs/specification.html#build-target-sources-request

  /** Either a text document or a directory. A directory entry must end with a forward
   * slash "/" and a directory entry implies that every nested text document within the
   * directory belongs to this source item.
   */

[heksesang]

Have you tried to just set the source path of mill-build root project to . or millSourcePath?

set source path to . or millSourcePath may be inappropriate too

https://build-server-protocol.github.io/docs/specification.html#build-target-sources-request

  /** Either a text document or a directory. A directory entry must end with a forward
   * slash "/" and a directory entry implies that every nested text document within the
   * directory belongs to this source item.
   */

The path will be translated to an absolute path, though? Which would end with a forward slash.

Ah, but every document could be considered to belong to the build target. That is obviously a problem.

[heksesang]

I don't know Ammonite well enough, but I think the answer is yet. Ammonite itself seems to provide BSP support, so the best would be to look into that implementation.

Back to this concrete PR, as src is in almost all cases not the right setting, but build.sc is probably too restricted. Have you tried to just set the source path of mill-build root project to . or millSourcePath?

src would in no normal circumstances match the build files, so if you change it to build.sc, I think it is no less restricted than before in practical terms.

[lefou]

Thank you!