Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support useECMAScript2015 option in ScalaJSModule #1004

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Support useECMAScript2015 option in ScalaJSModule #1004

merged 2 commits into from
Nov 17, 2020

Commits on Nov 17, 2020

  1. Support useECMAScript2015 option in ScalaJSModule 

    - Support ESModule ModuleKind
- Update Scala.js 0.6 to 0.6.33
- Update Scala.js 1 to 1.3.1
- Add useECMAScript2015 to test matrix just for last version
- Update Scala versions it tests
- Update ScalaJsUtils to use node.js instead of nashorn
  The initial idea was to use the NodeJSEnv from Scala.js to run the
  tests. But this created a problem since adding a particular NodeJSEnv
  to the classpath broke the other version of Scala.js linking. For example
  using NodeJSEnv from Scala.js 1.3.1 made fastOpt in Scala.js 0.6 break.
  So at the end the function is just calling "node" using `os.proc`
    @lolgab
    lolgab committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    226a573 View commit details
    Browse the repository at this point in the history

  2. Remove wrong comment about useECMAScript2015 ignored

    @lolgab
    lolgab committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ded0bac View commit details
    Browse the repository at this point in the history