Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestModule: add testOnly to select test suites in mill #1328

Merged
merged 4 commits into from
May 21, 2021

Conversation

chikei
Copy link
Contributor

@chikei chikei commented May 20, 2021

this is to support test class selection for frameworks do not support selection through runner arguments (for example, ScalaTest does not support class selection when running from sbt runner interface)

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature, thank you for this pull request! I left some comments inline.

scalalib/src/TestModule.scala Show resolved Hide resolved
scalalib/test/src/TestRunnerTests.scala Outdated Show resolved Hide resolved
scalalib/test/src/TestRunnerTests.scala Outdated Show resolved Hide resolved
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou merged commit 838e325 into com-lihaoyi:main May 21, 2021
@lefou lefou added this to the after 0.9.7 milestone May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants