replace FileSystems with ZipInputStream for parallel execution #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atty303
changed the title
lefou
reviewed
Sep 21, 2021
|
Thanks for the review!
I don't think there are any tests related to this. I have tested it working on a project at work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The steps to reproduce the problem are as follows.
scalaPBUnpackProtowill be executed in parallel.FileSystemAlreadyExistsExceptionwill be thrown.This is because FileSystems does not allow multiple instances of the same URI to be created.
Therefore, I have changed the implementation to use ZipInputStream.