Fix URL to file path conversion for GenIdea command #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
approved these changes
Nov 24, 2021
pbuszka
pushed a commit
to pbuszka/mill
that referenced
this pull request
Dec 26, 2021
Fixes artifacts resolving from private repos for GenIdea command. **Problem description**: Coursier caches private repos under the `.../user@organization/...` path, for unix systems it translates to `.../user%40organization/...` path, and in turn `java.net.URL` translates it to `.../user%2540organization/...`, so when GenIdea constructs `buildDepsPaths` with OS independent `java.net.URL#getFile` call, double escaping breaks pathes for private repos. **Fix description**: OS idependent URL to file path conversion `java.net.URL#getFile` was replaced with OS dependent `java.nio.file.Paths#get(java.net.URI)` Pull request: com-lihaoyi#1587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes artifacts resolving from private repos for GenIdea command.
Problem description:
Coursier caches private repos under the
.../user@organization/...path, for unix systems it translates to.../user%40organization/...path, and in turnjava.net.URLtranslates it to.../user%2540organization/..., so when GenIdea constructsbuildDepsPathswith OS independentjava.net.URL#getFilecall, double escaping breaks pathes for private repos.Fix description:
OS idependent URL to file path conversion
java.net.URL#getFilewas replaced with OS dependentjava.nio.file.Paths#get(java.net.URI)