Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about "Switch Build Server" in Metals. #1594

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

ckipp01
Copy link
Collaborator

@ckipp01 ckipp01 commented Nov 29, 2021

Now that scalameta/metals#3308 is merged Metals can actually detect (based on mill version) if the current workspace can use Mill as a BSP server even if there is no .bsp/mill-bsp.json created yet. If the users selects this, it will automatically create the .bsp/mill-bsp.json file and then connect to mill. This pr just clarifies this in the docs and mentions the "Switch Build Server" command they'll need to use.

Just to show an example, you can see here there is no bsp entry, but it's still shown as an option:

2021-11-29 19 06 17

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou merged commit 538ffe2 into com-lihaoyi:main Nov 29, 2021
@lefou lefou added this to the after 0.10.0-M4 milestone Nov 29, 2021
@ckipp01 ckipp01 deleted the metalsDocs branch November 30, 2021 08:17
pbuszka pushed a commit to pbuszka/mill that referenced this pull request Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants