Update zinc to 1.5.8 #1613
Closed
Update zinc to 1.5.8 #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, we trigger an exception in zinc. Need to report it upstream... |
|
I opened issue sbt/zinc#1010 |
|
The test failure seem to be specific to our use of Scala 2.12.4 and a change in zinc. It's unlikely it will be fixed, so a workaround might be to change the Scala version in these tests. |
|
Yeah I would be fine dropping support for 2.12.4. In the Ammonite repo we dropped everything 2.12.7 and below. People have had plenty of time to upgrade, and point upgrades for Scala tend to be easy |
..as long as you don't use any rare compiler plugins. ;-) |
|
Superseded by #1624. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates org.scala-sbt:zinc from 1.5.7 to 1.5.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1