-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1625 fix transformer not picked up #1626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please avoid reformatting unchanged lines, but if, please use Scalafmt with our config.
f51cb33
to
fe7ee6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good now! 👍
I might come back with another PR because i have projects with multiple modules that depend on each and they all do scalaPB. |
Ah damn i just found 1 bug i have to add
|
@borissmidt Best is to add a test case to reproduce the bug and open a new PR with the test and it's fix. |
Yes indeed i just couldn't fix my initial problem that scalapb.options on package scope level of other projects and probably jars are not picked up. |
Fix issue: com-lihaoyi#1625 Pull request: com-lihaoyi#1626
fixes related issue #1625
It was easy to resolve the missing package context file by passing all files that need to be generated to protoc at once.
This is similar how sbt and gradle use protoc to compile the sources.