mill script is POSIX-compliant and has quoted paths. #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both mostly trivial changes.
The first one makes it so that the script works on systems where Bash is not symlinked to /bin/sh like Alpine Linux and FreeBSD. I'm not 100% sure what that line is trying to do. I read the commit (a41c632) that added it and I couldn't make sense of it. Either way,
BASH_SOURCE == BASH_SOURCE[0]which is equal to$0when the script isn't getting sourced. The script is meant to be run, not sourced, so the change should be fine.The second change just quotes the path in case someone's
XDG_CACHE_HOMEhas a space in it. And it's good for consistency.