Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to add properties to generated Maven pom #1646

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

lefou
Copy link
Member

@lefou lefou commented Dec 29, 2021

Also added a packaging attribute to PomSettings.

Also added a packaging attribute to PomSettings.
@lefou lefou requested a review from lihaoyi December 29, 2021 22:46
Copy link
Member

@lolgab lolgab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
About the version scheme I was defining in the other PR, how does it play together with publishProperties?

@lefou lefou merged commit 133f2b1 into com-lihaoyi:main Dec 30, 2021
@lefou lefou deleted the pom-props branch December 30, 2021 09:23
@lefou lefou added this to the after 0.10.0-M5 milestone Dec 30, 2021
@lefou
Copy link
Member Author

lefou commented Dec 30, 2021

@lolgab I'm a bit unsure what the better approach for versionScheme is. We can have a dedicated def versionScheme as you did in #1629 and derive the publishProperties from it, or we can provide some kind of constants to be used in publishProperties directly. Something like:

object VersionScheme {
  val Strict = ("info.versionScheme", "strict")
  ...
}

def publishProperties = Map(VersionScheme.Strict)

I like the former approach more.

I still struggle to find information if and how these properties are supported in ivy.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants