Fix Scala Native for versions > 0.4.2
#1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workers in Mill work (pun not intended) by compiling to a base version and then substitute the classloader with the dependencies from the project they are compiling.
Before this PR, the Scala Native worker dependency was a uberjar created with
assemblyso it was depending on the Scala Native version defined in Mill'sbuild.sc.Now worker contains only the Worker classes and all the other dependencies are injected by Mill using the
scalaNativeVersionfrom theScalaNativeModuleit is compiling.