Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub asset upload #1681

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Fix GitHub asset upload #1681

merged 2 commits into from
Jan 17, 2022

Conversation

lefou
Copy link
Member

@lefou lefou commented Jan 17, 2022

Removed support for shortening URLs. git.io no longer accepts new URLs.

It seems to fail when shortening the URL.
As I don't know why we need to short url (we don't process it)
I just gracefully continue by returning the long URL.

I did investigated why shortening the URL no longer works.
@lefou lefou changed the title Fix Github asset upload Fix GitHub asset upload Jan 17, 2022
@lefou lefou marked this pull request as ready for review January 17, 2022 19:46
@lefou lefou merged commit 8753cb6 into com-lihaoyi:main Jan 17, 2022
@lefou lefou deleted the fix-github-upload branch January 17, 2022 19:49
@lefou lefou added this to the after 0.10.0 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant