Migrate to new Scala.js Linker API #1685
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala.js linker now supports multiple top-level modules: https://www.scala-js.org/doc/project/module.html.
Currently, Mill fails to link those setup as it is using deprecated Linker API. See #1684.
This PR is my attempt to migrate to the new API that solves the issue.
As I'm new to the project, please let me know what else might be impacted by the change. I've managed to get my original issue with
fastOpt
resolved. Still need to test thetest
command as well.