Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zinc to 1.6.1 #1700

Merged
merged 8 commits into from
Jan 28, 2022
Merged

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-sbt:zinc from 1.5.9 to 1.6.1.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "zinc" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@lefou lefou mentioned this pull request Jan 28, 2022
@lefou
Copy link
Member

lefou commented Jan 28, 2022

After re-sync with merged #1713 , this PR should build successfully.

@lolgab
Copy link
Member

lolgab commented Jan 28, 2022

@lefou This could be a good opportunity to remove the forced log4j core dependency since Zinc 1.6.1 already depends on 2.17.1

@lefou
Copy link
Member

lefou commented Jan 28, 2022

@lefou This could be a good opportunity to remove the forced log4j core dependency since Zinc 1.6.1 already depends on 2.17.1

I'm a huge fan of explicit dependencies. Hence I'd like to keep it, especially now, as many people are aware of issues with Log4j2 and are seeking for the concrete version Mill might use. Unless zinc drops it, it doesn't hurt to keep it declared. If next zinc pulls a newer version, we'll get it automatically. If they don't, we or probably scala-steward will bump it and we are also good to go.

@lefou lefou merged commit fcf5ac2 into com-lihaoyi:main Jan 28, 2022
@lefou lefou added this to the after 0.10.0 milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants