Do not clutter user home directory with mill-release binary
#1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, we now create that file locally under `target/mill-release`. Also, it is no longer hard coded into the (forked) test suite, but instead read from the `MILL_TEST_RELEASE` system environment variable.
lefou
force-pushed
the
mill-release-relocation
branch
from
a1380b6
to
dd9b488
Compare
lefou
force-pushed
the
mill-release-relocation
branch
from
195bb44
to
f85d55a
Compare
lolgab
reviewed
Mar 3, 2022
lolgab
reviewed
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we now create that file locally under
target/mill-release.Also, it is no longer hard coded into the (forked) test suite, but instead
read from the
MILL_TEST_RELEASEsystem environment variable.