Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a potential match error when show-ing failed tasks #1773

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

lefou
Copy link
Member

@lefou lefou commented Mar 10, 2022

I've witnessed this issue and also, that this PR fixes it, but I couldn't find a way to reproduce it in current test infrastructure. But better have the fix now then much later, I guess.

The situation is with Mill 0.10.1 and the project described in #1028 (comment)

$ rm -r ~/.cache/coursier/v1/https/repo1.maven.org/maven2/org/slf4j/slf4j-api/1.7.25/ ; mill clean ; mill -j 0 show __.resolvedIvyDeps
No mill version specified.
You should provide a version via '.mill-version' file or --mill-version option.
Using mill version 0.10.1
[1/1] clean 
No mill version specified.
You should provide a version via '.mill-version' file or --mill-version option.
Using mill version 0.10.1
[#00] [1/1] show 
[#05] [1/1] show > [97/120] foo[2].resolvedIvyDeps | Downloading [2/2] artifacts (~40/3873 bytes)
1 targets failed
show scala.MatchError: Watched(None,List()) (of class mill.util.Watched)
    mill.main.MainModule.$anonfun$show$5(MainModule.scala:275)
    mill.api.Result$Failure.$anonfun$map$1(Result.scala:67)
    scala.Option.map(Option.scala:242)
    mill.api.Result$Failure.map(Result.scala:67)
    mill.api.Result$Failure.map(Result.scala:66)
    mill.main.MainModule.$anonfun$show$1(MainModule.scala:274)
    mill.define.Task$TraverseCtx.evaluate(Task.scala:379)

@lefou lefou merged commit c4b159a into com-lihaoyi:main Mar 10, 2022
@lefou lefou deleted the show-failed-tasks branch March 10, 2022 14:30
@lefou lefou added this to the after 0.10.1 milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant