Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect module traversal for BSP classpath retrieval #1793

Merged
merged 5 commits into from
Mar 25, 2022
Merged

Fix incorrect module traversal for BSP classpath retrieval #1793

merged 5 commits into from
Mar 25, 2022

Conversation

lefou
Copy link
Member

@lefou lefou commented Mar 24, 2022

Issue reported in #1792 by @abernardi597.

@lefou
Copy link
Member Author

lefou commented Mar 24, 2022

@abernardi597 I added a test case which detects the incorrect bspCompileClasspath implementation and also added the fix.

@lefou lefou marked this pull request as ready for review March 24, 2022 19:40
@lefou lefou mentioned this pull request Mar 24, 2022
Closed
@lefou lefou merged commit 399bce1 into main Mar 25, 2022
@lefou lefou deleted the fix-bsp branch March 25, 2022 08:02
@lefou lefou added this to the after 0.10.2 milestone Mar 25, 2022
@lefou lefou mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.3
Development

Successfully merging this pull request may close these issues.
1 participant
@lefou