-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked some BSP module inspection tasks #1803
Conversation
This should improve (fix) performance and OOM issues with large multi module projects where modules depend heavily on each other.
Turns out, Mill's |
I have the feeling that our `mill.api.internal` annotation is ignored. I added some ignore rules manually to get CI green, but I'm not sure if it is actually safe to change the signature of these`bspXxx` methods. It should, as they are only used internally, but my detailed knowledge of trait encoding into classes/objects is a bit rusty.
@lefou There is a bug in Opened an issue here: lolgab/mill-mima#41 |
This should improve (fix) performance and OOM issues with large multi module projects where modules depend heavily on each other.
bspCompileClassesPath
andbspCompileClasspath
are now Targets instead of Tasks. This makes them cacheable and also easier to override in derived modules. I also changed the logic in sometransitiveXXX
targets from a recursive call to all dependencies to just calling the non-recursive target on a transitive modules list. This should mitigate OOM issue as reported here: #1792 (comment)Fix #1792
Supersedes #1794