Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zinc to 1.7.1 #1845

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Update zinc to 1.7.1 #1845

merged 4 commits into from
Jul 12, 2022

Conversation

lefou
Copy link
Member

@lefou lefou commented Apr 19, 2022 •
edited
Loading

No description provided.

ckipp01 added a commit to ckipp01/mill that referenced this pull request Jul 1, 2022
@ckipp01
Bump zinc and account for diagnostic code
4063921 
At the moment this is just testing a bit. I see you already have a test
PR to bump zinc in com-lihaoyi#1845 but one
of the things that this brings in is the changes to `Problem` I made in
sbt/sbt#6874 that expose the diagnostic code of
the diagnostic coming from dotc. I have been doing some work on that on
the compiler side in scala/scala3#15565 and
wanted to try it out with Mill.

I tried to mimic the way you currently have it set up, so let me know if
it's not the direction you'd want to go. However, the idea here would be
that the diagnostic code is forwarded when diagnostics are published via
BSP so that Metals could then capture that code and know what code
actions to offer. You can see more of the big picture in scala/scala3#14904.
@ckipp01 ckipp01 mentioned this pull request Jul 1, 2022
Merged
@lefou lefou changed the title Update zinc to 1.7.0-M2 Update zinc to 1.7.0 Jul 11, 2022
@lefou lefou marked this pull request as ready for review July 11, 2022 07:20
@lefou lefou mentioned this pull request Jul 12, 2022
Closed
@lefou lefou changed the title Update zinc to 1.7.0 Update zinc to 1.7.1 Jul 12, 2022
@lefou lefou mentioned this pull request Jul 12, 2022
Closed
@lefou lefou merged commit c88f8f9 into com-lihaoyi:main Jul 12, 2022
@lefou lefou deleted the zinc branch July 12, 2022 13:14
@lefou lefou added this to the after 0.10.5 milestone Jul 12, 2022
ckipp01 added a commit to ckipp01/mill that referenced this pull request Jul 22, 2022
@ckipp01
Bump zinc and account for diagnostic code
0ab83de 
At the moment this is just testing a bit. I see you already have a test
PR to bump zinc in com-lihaoyi#1845 but one
of the things that this brings in is the changes to `Problem` I made in
sbt/sbt#6874 that expose the diagnostic code of
the diagnostic coming from dotc. I have been doing some work on that on
the compiler side in scala/scala3#15565 and
wanted to try it out with Mill.

I tried to mimic the way you currently have it set up, so let me know if
it's not the direction you'd want to go. However, the idea here would be
that the diagnostic code is forwarded when diagnostics are published via
BSP so that Metals could then capture that code and know what code
actions to offer. You can see more of the big picture in scala/scala3#14904.
ckipp01 added a commit to ckipp01/mill that referenced this pull request Aug 7, 2022
@ckipp01
Bump zinc and account for diagnostic code
8520913 
At the moment this is just testing a bit. I see you already have a test
PR to bump zinc in com-lihaoyi#1845 but one
of the things that this brings in is the changes to `Problem` I made in
sbt/sbt#6874 that expose the diagnostic code of
the diagnostic coming from dotc. I have been doing some work on that on
the compiler side in scala/scala3#15565 and
wanted to try it out with Mill.

I tried to mimic the way you currently have it set up, so let me know if
it's not the direction you'd want to go. However, the idea here would be
that the diagnostic code is forwarded when diagnostics are published via
BSP so that Metals could then capture that code and know what code
actions to offer. You can see more of the big picture in scala/scala3#14904.
ckipp01 added a commit to ckipp01/mill that referenced this pull request Oct 3, 2022
@ckipp01
Bump zinc and account for diagnostic code
84f81a8 
At the moment this is just testing a bit. I see you already have a test
PR to bump zinc in com-lihaoyi#1845 but one
of the things that this brings in is the changes to `Problem` I made in
sbt/sbt#6874 that expose the diagnostic code of
the diagnostic coming from dotc. I have been doing some work on that on
the compiler side in scala/scala3#15565 and
wanted to try it out with Mill.

I tried to mimic the way you currently have it set up, so let me know if
it's not the direction you'd want to go. However, the idea here would be
that the diagnostic code is forwarded when diagnostics are published via
BSP so that Metals could then capture that code and know what code
actions to offer. You can see more of the big picture in scala/scala3#14904.
ckipp01 added a commit to ckipp01/mill that referenced this pull request Oct 8, 2022
@ckipp01
Bump zinc and account for diagnostic code
08e9b7f 
At the moment this is just testing a bit. I see you already have a test
PR to bump zinc in com-lihaoyi#1845 but one
of the things that this brings in is the changes to `Problem` I made in
sbt/sbt#6874 that expose the diagnostic code of
the diagnostic coming from dotc. I have been doing some work on that on
the compiler side in scala/scala3#15565 and
wanted to try it out with Mill.

I tried to mimic the way you currently have it set up, so let me know if
it's not the direction you'd want to go. However, the idea here would be
that the diagnostic code is forwarded when diagnostics are published via
BSP so that Metals could then capture that code and know what code
actions to offer. You can see more of the big picture in scala/scala3#14904.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.6
Development

Successfully merging this pull request may close these issues.
1 participant
@lefou