Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistency in args parser #2030

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 9, 2022

Since we support separated arguments, we first separate all arguemnts and
later valdate and extract each separated group individualy.
When we get no args at all, we create no separated groups, hence we dont
have anything to validate and we miss to create a parse error for it.

This fix instead creates an empty first separated group, so we properly
validate it and detect the case of missing args.

Since we support separated arguments, we first separate all arguemnts and
later valdate and extract each separated group individualy.
When we get no args at all, we create no separated groups, hence we dont
have anything to validate and we miss to create a parse error for it.

This fix instead creates an empty first separated group, so we properly
validate it and detect the case of missing args.
@lefou lefou merged commit d5a14a8 into com-lihaoyi:main Sep 15, 2022
@lefou lefou deleted the fix-args-parser branch September 15, 2022 14:26
@lefou lefou added this to the after 0.10.7 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant