-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support incremental compilation in Scala Native 0.4.9 #2141
Conversation
0492bc3
to
ecf02ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition. Would be good to seen it working in some test, tough.
I thought about that. Since it doesn't change the binary behaviour, it's hard to assert it's working without assumptions that will probably break on the next version (since it's an experimental feature). Also Scala Native tests are expensive. If you think we need it I can add it. I just manual tested it in scratch. |
I see. As I'm not familiar with Scala Native API, I can't tell whether it is easy, possible ,or useless, but maybe we can add some unit test just comparing the expected with the actual used config? |
@lefou Added a test that exercises the incremental compilation feature in Scala Native (the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for adding the extra test.
I wonder, whether we want to print a warning message, when a feature is enabled but ignored, because of an unsupported version.
Scala Native 0.4.9 added support for this feature: https://github.com/scala-native/scala-native/releases/tag/v0.4.9