Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ivyDepsTree and transitive dep management #2175

Merged
merged 9 commits into from
Dec 15, 2022
Merged

Document ivyDepsTree and transitive dep management #2175

merged 9 commits into from
Dec 15, 2022

Conversation

james-s-w-clark
Copy link
Contributor

Thanks @lefou for adding these docs!

@james-s-w-clark james-s-w-clark marked this pull request as ready for review December 8, 2022 09:00
lefou
lefou reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I left some small remarks. Also, some example output for ivyDepsTree would be nice.

docs/antora/modules/ROOT/pages/Library_Dependencies.adoc Outdated Show resolved Hide resolved
docs/antora/modules/ROOT/pages/Library_Dependencies.adoc Outdated Show resolved Hide resolved
docs/antora/modules/ROOT/pages/Library_Dependencies.adoc Outdated Show resolved Hide resolved
@james-s-w-clark
Copy link
Contributor Author

Thank you. I left some small remarks. Also, some example output for ivyDepsTree would be nice.

I'll make the improvements later, thanks for the feedback :)

I will also add a little bit about resolvedIvyDeps and how to render them in terminal - credit to @ollyw

lefou
lefou approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you, James!

@lefou lefou changed the title docs: document ivyDepsTree & give example of excluding a transitive dep Document ivyDepsTree and transitive dep management Dec 15, 2022
@lefou lefou changed the title Document ivyDepsTree and transitive dep management Document ivyDepsTree and transitive dep management Dec 15, 2022
@lefou lefou merged commit 88d3812 into com-lihaoyi:main Dec 15, 2022
@lefou lefou added this to the 0.11.0-M1 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@james-s-w-clark @lefou