Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PathRef hashCode for workers caches #2189

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Use PathRef hashCode for workers caches #2189

merged 1 commit into from
Dec 12, 2022

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Dec 10, 2022 •
edited
Loading

Porting the approach used for the Zinc and Scala.js workers to all the workers used in the mill codebase.

@lolgab lolgab marked this pull request as ready for review December 11, 2022 09:56
@lolgab lolgab requested a review from lefou December 11, 2022 09:56
@lolgab
Copy link
Member Author

lolgab commented Dec 11, 2022

I first pushed on the com-lihaoyi remote by mistake, that's why there are a bunch of cancelled jobs.

lefou
lefou approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't know we were using os.mtime that much. Nice to see it removed. Thank you!

@lefou lefou merged commit ba4486f into com-lihaoyi:main Dec 12, 2022
@lefou lefou added this to the 0.11.0-M1 milestone Dec 12, 2022
@lolgab lolgab deleted the faster-workers branch December 12, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @lefou