Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Resolve.scala and related code to improve rigor and error reporting #2453

Merged
merged 60 commits into from
Apr 26, 2023
Merged

Clean up Resolve.scala and related code to improve rigor and error reporting #2453

merged 60 commits into from
Apr 26, 2023

Commits on Apr 23, 2023

  1. add module-init-error test

    @lihaoyi
    lihaoyi committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    3abfa6b View commit details
    Browse the repository at this point in the history

  2. flesh out ModuleInitErrorTests

    @lihaoyi
    lihaoyi committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    5cc0e35 View commit details
    Browse the repository at this point in the history

  3. fix

    @lihaoyi
    lihaoyi committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    9794eaf View commit details
    Browse the repository at this point in the history

  4. wip try to collapse Resolve into one impl

    @lihaoyi
    lihaoyi committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    f06baed View commit details
    Browse the repository at this point in the history

  5. ResolveTasks compiles again with new implementation, incomplete

    @lihaoyi
    lihaoyi committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    00f0178 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. try to re-introduce resolve error reporting

    @lihaoyi
    lihaoyi committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    718be72 View commit details
    Browse the repository at this point in the history

  2. wip

    @lihaoyi
    lihaoyi committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    092120d View commit details
    Browse the repository at this point in the history

  3. re-implement not-a-module error

    @lihaoyi
    lihaoyi committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    d5a1d2e View commit details
    Browse the repository at this point in the history

  4. wip

    @lihaoyi
    lihaoyi committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    dfc4328 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. iwp

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1d4b411 View commit details
    Browse the repository at this point in the history

  2. fixes

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    363e482 View commit details
    Browse the repository at this point in the history

  3. all MainTests pass

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    d35f58b View commit details
    Browse the repository at this point in the history

  4. add doubleNestedModule tests, enable more tests

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    cd9c0ca View commit details
    Browse the repository at this point in the history

  5. try and re-enable other uses of resolve

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    add13e1 View commit details
    Browse the repository at this point in the history

  6. all main.test passes

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    4b95cc4 View commit details
    Browse the repository at this point in the history

  7. break out ResolveNonEmpty

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    184dfcb View commit details
    Browse the repository at this point in the history

  8. fix-compile

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    c07f8b0 View commit details
    Browse the repository at this point in the history

  9. scalafmt

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    fa085b8 View commit details
    Browse the repository at this point in the history

  10. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9e7a40b View commit details
    Browse the repository at this point in the history

  11. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    35cfef0 View commit details
    Browse the repository at this point in the history

  12. wip

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    4862477 View commit details
    Browse the repository at this point in the history

  13. split out ExpandBracesTests

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    b274839 View commit details
    Browse the repository at this point in the history

  14. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    3e186c8 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into module-init-error

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    cea7c6c View commit details
    Browse the repository at this point in the history

  16. fix

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    424a1a9 View commit details
    Browse the repository at this point in the history

  17. fixes

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    4669340 View commit details
    Browse the repository at this point in the history

  18. resolveTasks -> resolve

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a229e4d View commit details
    Browse the repository at this point in the history

  19. things compile again after trying to make reflection return an Either

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    7b74968 View commit details
    Browse the repository at this point in the history

  20. first few module initialization error unit tests pass

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1655c51 View commit details
    Browse the repository at this point in the history

  21. comments

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9881f0d View commit details
    Browse the repository at this point in the history

  22. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    0de8d03 View commit details
    Browse the repository at this point in the history

  23. simple cross module partial initialization failure test

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    296f4ec View commit details
    Browse the repository at this point in the history

  24. simple cross module initialization failure

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    ca65172 View commit details
    Browse the repository at this point in the history

  25. wip

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a430a0b View commit details
    Browse the repository at this point in the history

  26. add ResolveMetadata testing to ResolversTests.scala

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    2c57075 View commit details
    Browse the repository at this point in the history

  27. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    2ee6597 View commit details
    Browse the repository at this point in the history

  28. scalafmt

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    e2bb92f View commit details
    Browse the repository at this point in the history

  29. wip getting rid of rev List[Segment]

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    8f111a4 View commit details
    Browse the repository at this point in the history

  30. fix-tests

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    db51286 View commit details
    Browse the repository at this point in the history

  31. fix-compile

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    6c7bc42 View commit details
    Browse the repository at this point in the history

  32. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a4dfa70 View commit details
    Browse the repository at this point in the history

  33. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    096e6c4 View commit details
    Browse the repository at this point in the history

  34. add dependency test cases, assert stack traces are shortish

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a1fdd47 View commit details
    Browse the repository at this point in the history

  35. ensure output of resolution gets sorted

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    17fd69b View commit details
    Browse the repository at this point in the history

  36. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    2e8bb12 View commit details
    Browse the repository at this point in the history

  37. fox

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    c3b100d View commit details
    Browse the repository at this point in the history

  38. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    5071c2c View commit details
    Browse the repository at this point in the history

  39. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    540ddf7 View commit details
    Browse the repository at this point in the history

  40. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    12c844f View commit details
    Browse the repository at this point in the history

  41. cleanup

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    78f62b5 View commit details
    Browse the repository at this point in the history

  42. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    53b1914 View commit details
    Browse the repository at this point in the history

  43. Merge branch 'main' into module-init-error

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    695280a View commit details
    Browse the repository at this point in the history

  44. try to fix getSimpleName on JDK8

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    09e7484 View commit details
    Browse the repository at this point in the history

  45. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    d9ca2f8 View commit details
    Browse the repository at this point in the history

  46. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    18d7a6d View commit details
    Browse the repository at this point in the history

  47. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    6079a36 View commit details
    Browse the repository at this point in the history

  48. .

    @lihaoyi
    lihaoyi committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    5f174bf View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. tweaks

    @lihaoyi
    lihaoyi committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    fc6b17f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into module-init-error

    @lihaoyi
    lihaoyi committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4df0166 View commit details
    Browse the repository at this point in the history

  3. .

    @lihaoyi
    lihaoyi committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6b5f726 View commit details
    Browse the repository at this point in the history