Move mill.BuildInfo
tomill.main.BuildInfo
#2537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently encourage
import mill._
, which causes problems when people want to alsoimport mill.contrib.buildinfo.BuildInfo
. There's a workaround toimport mill.{BuildInfo => MillBuildInfo, _}
, which we do in several places in our own codebase, but it's a pain in the neck and an unnecessary hurdle for users to cross. The majority of users would not need to accessmill.BuildInfo
at all, so putting it in the default namespace just adds clutter.The
mill.BuildInfo
is used throughoutmill.scalalib
andmill.scalajslib
and so on, but is not used inmain/
, so I put it in as downstream a module as possible which turns out to bemill.main.BuildInfo