Add support for multi-release Jar files #2724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user configures javacOptions to include Seq("--release", "17"),
for example, then multi-release Jar files will be opened and processed
accordingly.
Flowdalic
force-pushed
the
multi-release
branch
from
304fc58
to
0932c20
Compare
Flowdalic
force-pushed
the
multi-release
branch
from
60f41fc
to
c450221
Compare
lefou
reviewed
Sep 8, 2023
There was a problem hiding this comment.
I think dropping Java 8 support for such an rarely used feature is not an option.
As discussed in the chat, adding a Multi-Release: true header to the manifest of the assembly jar is enough to let the JVM recognize the incorporated multi-release jars.
|
Right, I am not even convinced that the approach of this PR is sensible. You probably want the Multi-Release classes even if you build with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user configures javacOptions to include Seq("--release", "17"), for example, then multi-release Jar files will be opened and processed accordingly.
Mill not being able to consume multi-release Jar files is leading to superfluous warnings because of code paths for older JREs being used.