[BSP] Use consistent file URI format #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were emitting different URI formats if the sourceFile info was missing or not. Not sure if this is a problem, but targetId.getUri is returning files as `file:///foo/bar/file.scala` while our `java.io.File` `toURI` returns `file:/foo/bar/file.scala` Changing it to `.toPath.toUri` for consistency
lefou
reviewed
Sep 30, 2023
There was a problem hiding this comment.
So, we now always have file:/// for local file URIs?
I know there were other issues (Exceptions) when converting files to URIs, but I can't remember the details right now. Could be some Windows specific thing, but until I recall, we can just ignore that. Using toPath looks ok, but we should definitely leave a comment in the code indicating it's purpose.
lefou
reviewed
Oct 2, 2023
lefou
approved these changes
Oct 2, 2023
lefou
reviewed
Oct 2, 2023
|
Thank you for making the changes for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were emitting different URI formats if the sourceFile info was missing or not.
Not sure if this is a problem, but
targetId.getUriis returning files asfile:///foo/bar/file.scalawhile ourjava.io.FiletoURIreturnsfile:/foo/bar/file.scalaChanging it to
.toPath.toUrifor consistency