Cleanup BSP server implementation #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid BSP server integration when generating the semanticdb data - Make BSPCompileProblemReporter thread unsafe since can be called from a single thread (the Scala compiler is single threaded, now only one compilation has BSP and every module gets its own instance) - Start sending partial events to BSP using `reset = false` when the compiler reports a problem. Before we were sending all the issues every time, by using the `reset = true` flag. Now we send one problem at a time using `reset = false` and at the end of the compilation we send them all using `reset = true` (which happens in `fileVisited`)
lefou
reviewed
Oct 3, 2023
|
I think it can be useful in the future if we want to avoid allocating a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset = falsewhen the compiler reports a problem. Before we were sending all the issues every time, by using thereset = trueflag. Now we send one problem at a time usingreset = falseand at the end of the compilation we send them all usingreset = true(which happens infileVisited)