Use semanticdb files directly in ScalaModule #3078
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A copy mechanism was introduced in com-lihaoyi#2227 because of a bug in semanticdb-java But we don't need to use it in ScalaModule as well if the Scala semanticdb works correctly.
lolgab
force-pushed
the
avoid-copy-semanticdb-scala
branch
from
494cac1
to
2b41c5c
Compare
|
There are test failures. Also, I'd like to get PR #3080 in before, which brings additional test for incremental semanticDB generation. |
lefou
reviewed
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy mechanism was introduced in #2227 because of a bug in semanticdb-java
But we don't need to use it in ScalaModule as well if the Scala semanticdb works correctly.