Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 2.13.14 to bridgeScalaVersions #3166

Merged
merged 2 commits into from
May 23, 2024

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented May 18, 2024

Add comment to scalaVersion

Pull Request: #3166

Add comment to `scalaVersion`
@@ -52,6 +52,8 @@ object Settings {
object Deps {

// The Scala version to use
// When updating, run "Publish Bridges" Github Actions for the new version
// and then add to it `bridgeScalaVersions`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should auto-add all required verions (scalaVersion, workerScalaVersion212, probably scalaVersionForScoverageWorker1) to bridgeScalaVersions.

@lefou
Copy link
Member

lefou commented May 22, 2024

@lefou lefou marked this pull request as ready for review May 23, 2024 06:53
@lefou lefou merged commit 6aae6d9 into com-lihaoyi:main May 23, 2024
39 checks passed
@lefou lefou added this to the 0.11.8 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants