Add unit tests to the JUnit xml report generation #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-gilles-ultra
changed the title
lefou
reviewed
May 24, 2024
| @@ -386,9 +387,11 @@ object TestModule { | |||
| tests={testResults.length.toString} | |||
| failures={testResults.count(_.status == Status.Failure.toString).toString} | |||
| errors={testResults.count(_.status == Status.Error.toString).toString} | |||
| skipped={testResults.count(_.status == Status.Skipped.toString).toString} | |||
| skipped={ | |||
| testResults.count(testResult => SkippedStatus.contains(testResult.status)).toString | |||
There was a problem hiding this comment.
You sometimes use Status.toString and sometimes Status.name(). Is there a difference? Can we always use name ?
There was a problem hiding this comment.
Hi @lefou
You are right I should always use the Enum.name() function which is the right function to get the string representation of the enum name. I will fix it. BTW I introduced constants for those names it's my mistake to not use them here ;)
lefou
reviewed
May 24, 2024
| @@ -206,6 +206,10 @@ trait TestModule | |||
|
|
|||
| object TestModule { | |||
| private val FailedTestReportCount = 5 | |||
| private val ErrorStatus = Status.Error.name() | |||
| private val FailureStatus = Status.Failure.name() | |||
| private val SkippedStatus = | |||
There was a problem hiding this comment.
Should this be plural?
Suggested change
| private val SkippedStatus = | |
| private val SkippedStates = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to the JUnit XML report generation.