Add a Netty example `build.sc` and write about it #3326

lihaoyi · 2024-07-31T07:36:43Z

No description provided.

lefou

Great case study.

lefou · 2024-07-31T08:22:50Z

docs/modules/ROOT/pages/Java_Case_Study.adoc

+$ time ./mvnw -DskipTests  -Dcheckstyle.skip -Denforcer.skip=true clean install
+
+$ time ./mill clean __.compile


I think these are not fair comparisions. We either also run jar in Mill or we don't install in Maven.

Suggested change

$ time ./mvnw -DskipTests -Dcheckstyle.skip -Denforcer.skip=true clean install

$ time ./mill clean __.compile

$ time ./mvnw -DskipTests -Dcheckstyle.skip -Denforcer.skip=true clean compile testCompile

$ time ./mill clean __.compile

Running just compile sometimes works in a Maven reactor build, sometimes not. Need to check.

Alternatively, we need to run jar in Mill.

Suggested change

$ time ./mvnw -DskipTests -Dcheckstyle.skip -Denforcer.skip=true clean install

$ time ./mill clean __.compile

$ time ./mvnw -DskipTests -Dcheckstyle.skip -Denforcer.skip=true clean install

$ time ./mill clean __.jar

The thing is, in Mill the common workflow is running compile, while in Maven the equivalent workflow is running install. AFAICT, this is because Maven uses ~/.m2/local for passing dependencies between subprojects, while Mill doesn't.

Part of the reason Mill is faster is because it does less work, but I don't think that makes the comparison unfair. In the end, nobody runs compile in Maven or jar in Mill. mvn install and mill compile are equivalent user workflows

docs/modules/ROOT/pages/Java_Case_Study.adoc

lefou · 2024-07-31T09:53:10Z

docs/modules/ROOT/pages/Java_Case_Study.adoc

+In general, the Mill snippet contains all the same information as the Maven snippet: the name
+of the module and its dependency on `common`. Much of the other information in the Maven XML
+is inherited from the `trait NettyModule` we defined earlier in the file, where it can be
+shared with the rest of the modules rather than being duplicated for each one. This means


Suggested change

shared with the rest of the modules rather than being duplicated for each one. This means

shared with the rest of the modules rather than being duplicated for each one.

lefou · 2024-07-31T09:54:48Z

docs/modules/ROOT/pages/Java_Case_Study.adoc

+
+While Mill cannot make the complexity of your build disappear, what it can do is give you
+the tools necessary to manage it. In this case, it means the JNI-related logic can be defined
+once and re-used, rather than duplicating it as is often done in Maven `pom.xml`s.


Suggested change

once and re-used, rather than duplicating it as is often done in Maven `pom.xml`s.

once and re-used, rather than duplicating it as is often done in Maven ``pom.xml``s.

lefou · 2024-07-31T09:58:46Z

docs/modules/ROOT/pages/Java_Case_Study.adoc

+    val context = new java.util.HashMap[String, Object]
+
+    context.put("collection.template.dir", "common/src/main/templates")
+    context.put("collection.template.test.dir", "common/src/test/templates")
+    context.put("collection.src.dir", (T.dest / "src").toString)
+    context.put("collection.testsrc.dir", (T.dest / "testsrc").toString)
+
+    shell.setProperty("properties", context)


Suggested change

val context = new java.util.HashMap[String, Object]

context.put("collection.template.dir", "common/src/main/templates")

context.put("collection.template.test.dir", "common/src/test/templates")

context.put("collection.src.dir", (T.dest / "src").toString)

context.put("collection.testsrc.dir", (T.dest / "testsrc").toString)

shell.setProperty("properties", context)

val context = Map[String, Object](

"collection.template.dir" -> "common/src/main/templates",

"collection.template.test.dir" -> "common/src/test/templates",

"collection.src.dir" -> (T.dest / "src").toString,

"collection.testsrc.dir" -> (T.dest / "testsrc").toString

)

import scala.jdk.CollectionConverters._

shell.setProperty("properties", context.asJava)

I'd like to leave this as is, since we're interoping with Java libraries, and this example is meant to be readable to Java programmers. Scala is more idiomatic Mill, but staying in java.util.HashMap-land will be much more familiar and less scary

I almost expected this answer as I had the same thought. ;)

lefou · 2024-08-01T07:28:29Z

docs/modules/ROOT/pages/Java_Case_Study_Netty.adoc

@@ -16,46 +16,334 @@ To do this, we have written a Mill `build.sc` file for the Netty project. This c
 with Mill to build and test the various submodules of the Netty project without needing to
 change any other files in the repository:

- ???[Netty `build.sc` file]
+- https://github.com/com-lihaoyi/mill/blob/main/example/thirdparty/netty/build.sc[Netty `build.sc` file]


Suggested change

- https://github.com/com-lihaoyi/mill/blob/main/example/thirdparty/netty/build.sc[Netty `build.sc` file]

- {mill-github-url}/blob/main/example/thirdparty/netty/build.sc[Netty `build.sc` file]

.

64a4d50

lefou reviewed Jul 31, 2024

View reviewed changes

docs/modules/ROOT/pages/Java_Case_Study.adoc Outdated Show resolved Hide resolved

lefou reviewed Jul 31, 2024

View reviewed changes

lihaoyi added 8 commits August 1, 2024 07:57

.

fc859bb

.

fa8f7d4

Merge branch 'main' into netty

41bda3d

.

7058bfa

.

1e1f0c2

tweak brotli dep

c624b0e

tweak

1e07eff

.

af21b20

lefou reviewed Aug 1, 2024

View reviewed changes

lihaoyi added 7 commits August 1, 2024 16:00

fix

eb8be1b

.

ded1261

tweak

37701b4

.

617dfc3

.

a4f284b

.

cbb1032

.

1a3ec08

lihaoyi merged commit 5aa41b9 into com-lihaoyi:main Aug 3, 2024
39 checks passed

lefou changed the title ~~[WIP] Add a Netty example build.sc and write about it~~ Add a Netty example build.sc and write about it Aug 4, 2024

lefou modified the milestones: 0.11.12, 0.11.11 Aug 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a Netty example `build.sc` and write about it #3326

Add a Netty example `build.sc` and write about it #3326

lihaoyi commented Jul 31, 2024

lefou left a comment

lefou Jul 31, 2024 •

edited

Loading

lihaoyi Jul 31, 2024

lefou Jul 31, 2024

lefou Jul 31, 2024

lefou Jul 31, 2024

lihaoyi Jul 31, 2024

lefou Aug 1, 2024

lefou Aug 1, 2024

		$ time ./mvnw -DskipTests -Dcheckstyle.skip -Denforcer.skip=true clean install

		$ time ./mill clean __.compile

	shared with the rest of the modules rather than being duplicated for each one. This means
	shared with the rest of the modules rather than being duplicated for each one.

	once and re-used, rather than duplicating it as is often done in Maven `pom.xml`s.
	once and re-used, rather than duplicating it as is often done in Maven ``pom.xml``s.

-    val context = new java.util.HashMap[String, Object]
-    context.put("collection.template.dir", "common/src/main/templates")
-    context.put("collection.template.test.dir", "common/src/test/templates")
-    context.put("collection.src.dir", (T.dest / "src").toString)
-    context.put("collection.testsrc.dir", (T.dest / "testsrc").toString)
-    shell.setProperty("properties", context)
+    val context = Map[String, Object](
+      "collection.template.dir" -> "common/src/main/templates",
+      "collection.template.test.dir" -> "common/src/test/templates",
+      "collection.src.dir" -> (T.dest / "src").toString,
+      "collection.testsrc.dir" -> (T.dest / "testsrc").toString
+    )
+    import scala.jdk.CollectionConverters._
+    shell.setProperty("properties", context.asJava)

	- https://github.com/com-lihaoyi/mill/blob/main/example/thirdparty/netty/build.sc[Netty `build.sc` file]
	- {mill-github-url}/blob/main/example/thirdparty/netty/build.sc[Netty `build.sc` file]

Add a Netty example build.sc and write about it #3326

Add a Netty example build.sc and write about it #3326

Conversation

lihaoyi commented Jul 31, 2024

lefou left a comment

Choose a reason for hiding this comment

lefou Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

lihaoyi Jul 31, 2024

Choose a reason for hiding this comment

lefou Jul 31, 2024

Choose a reason for hiding this comment

lefou Jul 31, 2024

Choose a reason for hiding this comment

lefou Jul 31, 2024

Choose a reason for hiding this comment

lihaoyi Jul 31, 2024

Choose a reason for hiding this comment

lefou Aug 1, 2024

Choose a reason for hiding this comment

lefou Aug 1, 2024

Choose a reason for hiding this comment

Add a Netty example `build.sc` and write about it #3326

Add a Netty example `build.sc` and write about it #3326

lefou Jul 31, 2024 •

edited

Loading